Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve accessibility in patches page #206

Merged
merged 7 commits into from
Dec 31, 2023
Merged

Conversation

JMarques1196
Copy link
Contributor

Fixed Patches section accessibility issues by wrapping the elements causing the issue in li tags.
I've also updated the CSS rules to keep the same behavior.

Captura de Tela 2023-12-19 às 14 28 21

@oSumAtrIX oSumAtrIX changed the title fix: patches accessibility fix: Correct accessibility in patches section Dec 19, 2023
@oSumAtrIX oSumAtrIX changed the base branch from main to dev December 19, 2023 15:07
@oSumAtrIX oSumAtrIX requested a review from Ushie December 19, 2023 15:07
src/routes/patches/PatchItem.svelte Outdated Show resolved Hide resolved
@Ushie Ushie changed the title fix: Correct accessibility in patches section fix(Patches): Improve accessibility Dec 31, 2023
@Ushie Ushie changed the title fix(Patches): Improve accessibility fix: Improve accessibility in patches page Dec 31, 2023
@Ushie Ushie merged commit 425d0c3 into ReVanced:dev Dec 31, 2023
2 of 3 checks passed
@JMarques1196 JMarques1196 deleted the test/fix branch February 3, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants