New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add in doc another helpful usage of createMemoryHistory that was very… #374

Merged
merged 2 commits into from Dec 9, 2016

Conversation

2 participants
@slorber
Contributor

slorber commented Oct 7, 2016

… helpful for me

If you have a mobile website, that is also shipped as a Cordova app, and both have the same codebase, the Cordova app can use memory history, while the mobile website can use real browser history.
This way, the cordova app can stay on index.html of Cordova (which can be required for some UX/features, see EddyVerbruggen/Custom-URL-scheme#206 (comment))

Add in doc another helpful usage of createMemoryHistory that was very…
… helpful for me

If you have a mobile website, that is also shipped as a Cordova app, and both have the same codebase, the Cordova app can use memory history, while the mobile website can use real browser history.
This way, the cordova app can stay on index.html of Cordova (which can be required for some UX/features, see EddyVerbruggen/Custom-URL-scheme#206 (comment))
README.md Outdated
@@ -122,7 +122,8 @@ The `location` object implements a subset of [the `window.location` interface](h
Locations may also have the following properties:
- `location.state` - Some extra state for this location that does not reside in the URL (supported in `createBrowserHistory` and `createMemoryHistory`)
- `location.state` - Some extra state for this location that does not reside in the URL (supported in `createBrowserHistory` and `
`)

This comment has been minimized.

@mjackson

mjackson Oct 11, 2016

Member

Looks like this change wasn't intentional?

This comment has been minimized.

@slorber

slorber Oct 11, 2016

Contributor

good catch

@mjackson mjackson merged commit 8430f6f into ReactTraining:master Dec 9, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mjackson

This comment has been minimized.

Member

mjackson commented Dec 9, 2016

Thanks, @slorber!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment