New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always call listenBefore hooks on browser navigation #83

Merged
merged 1 commit into from Oct 7, 2015

Conversation

Projects
None yet
4 participants
@stevoland
Contributor

stevoland commented Oct 7, 2015

Fixes #71

@mjackson

This comment has been minimized.

Show comment
Hide comment
@mjackson

mjackson Oct 7, 2015

Member

Dude, this is one of the cleanest PRs I have ever seen, @stevoland. Thank you! 👏

Member

mjackson commented Oct 7, 2015

Dude, this is one of the cleanest PRs I have ever seen, @stevoland. Thank you! 👏

mjackson added a commit that referenced this pull request Oct 7, 2015

Merge pull request #83 from stevoland/listen-before
Always call listenBefore hooks on browser navigation

@mjackson mjackson merged commit 0cb36e3 into ReactTraining:master Oct 7, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@stevoland

This comment has been minimized.

Show comment
Hide comment
@stevoland

stevoland Oct 8, 2015

Contributor

Pleasure, thanks for your libraries

Contributor

stevoland commented Oct 8, 2015

Pleasure, thanks for your libraries

@cobbweb

This comment has been minimized.

Show comment
Hide comment
@cobbweb

cobbweb Dec 14, 2015

Why are these added as deprecated?

cobbweb commented on modules/createBrowserHistory.js in 39e080a Dec 14, 2015

Why are these added as deprecated?

This comment has been minimized.

Show comment
Hide comment
@taion

taion Dec 14, 2015

Contributor

You use listenBefore instead.

Contributor

taion replied Dec 14, 2015

You use listenBefore instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment