Add onChange callback #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjackson
reviewed
Aug 25, 2018
modules/Media.js
Outdated
|
|
||
| const { onQueryStateChange } = this.props; | ||
| if (onQueryStateChange) { | ||
| this.mediaQueryList.addListener(onQueryStateChange); |
There was a problem hiding this comment.
We already have a listener registered in updateMatches. We should call the onChange callback there instead of registering it as a separate listener.
edorivai
reviewed
Aug 27, 2018
modules/Media.js
Outdated
| @@ -16,7 +16,8 @@ class Media extends React.Component { | |||
| ]).isRequired, | |||
| render: PropTypes.func, | |||
| children: PropTypes.oneOfType([PropTypes.node, PropTypes.func]), | |||
| targetWindow: PropTypes.object | |||
| targetWindow: PropTypes.object, | |||
| onQueryStateChange: PropTypes.func | |||
olistic
force-pushed
the
onquerystatechange-callback
branch
from
9738a31
to
8b5e738
Compare
|
@mjackson just made your suggested changes and I'm happy with the final result. The |
|
This LGTM, I went ahead and merged it in! @mjackson let me know if you want some stuff tweaked afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #94.
Sorry I couldn't wait for confirmation on #94, but I needed this feature. I'm using my fork for the time being, but I'd prefer to go back to using the original pkg once (and if) this is merged here.
Thanks! 😄