Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Splitting Example Should Recommend react-loadable #5418

Closed
knpwrs opened this issue Aug 7, 2017 · 1 comment

Comments

2 participants
@knpwrs
Copy link
Contributor

commented Aug 7, 2017

I was following the code splitting example and ran into the problem that props would not be passed properly to the proxy-loaded component. I tried a few things and didn't get it working, but then I went and tried it with react-loadable and it worked out of the box, no fuss.

I can contribute documentation but I'm pretty much booked solid this week. This issue can serve as discussion, however.

@timdorr

This comment has been minimized.

Copy link
Collaborator

commented Aug 7, 2017

A better code splitting and data preloading example would be great. Docs changes are better discussed over PRs, so we can wait until that to pick this up.

@timdorr timdorr closed this Aug 7, 2017

@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.