Use only Codecov for coverage #3685

Merged
merged 1 commit into from Jul 29, 2016

Projects

None yet

2 participants

@taion
Contributor
taion commented Jul 29, 2016

It's just better than Coveralls.

@taion taion Use only Codecov for coverage
984081a
@timdorr
Collaborator
timdorr commented Jul 29, 2016

Just added the appropriate codecov.yml file too. Most configuration is done that way, so feel free to tweak settings from the defaults. I only have the automatic PR comment turned off.

@timdorr timdorr merged commit 892d965 into master Jul 29, 2016

3 checks passed

codecov/patch Coverage not affected when comparing 4fd1db5...984081a
Details
codecov/project 95.01% (+0.00%) compared to 4fd1db5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@timdorr timdorr deleted the codecov branch Jul 29, 2016
@taion
Contributor
taion commented Jul 29, 2016

Thanks! Wasn't sure whether it was intentional that we were still using the old UI-based override on Codecov. This brings things nicely in line though.

@timdorr
Collaborator
timdorr commented Jul 29, 2016

I had requested they turn it off on their end so we didn't have a file for a service we weren't really using. But now that we're using it, that's a non-issue :)

@timdorr
Collaborator
timdorr commented Jul 29, 2016

Settings are here: https://codecov.io/gh/reactjs/react-router/settings/yaml

They have a neat built-in doc viewer where you can click on a node and get the docs on it right there. Pretty cool!

@taion
Contributor
taion commented Jul 29, 2016

It's super neat. I had to ask their support to fix a few things yesterday to get the PR alerts, but that "patch" alert is super useful, since it directly measures what you care about for a PR, rather than showing you some tiny change to project coverage as a whole.

@timdorr timdorr referenced this pull request in reactjs/react-redux Aug 16, 2016
Merged

Switch to babel-plugin-istanbul and nyc #462

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment