This repository has been archived by the owner. It is now read-only.

feature: if no error function passed to subscribe, need to at least console.error #1417

Closed
born2net opened this Issue Feb 12, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@born2net
Copy link

born2net commented Feb 12, 2017

@feature: if no error function passed to subscribe, need to at least console.error!

I am working with rxjs5 and did not pass an error function handler for my subscription and sure enough my errors got trapped and never displayed to the console.
I believe that be default, if a user does not provide an error handler, the least rxjs should do is catch the error and console.error() so new users (and old ones who forget) will be notified of swallowed bugs.

this relates also to Ben's blog:
https://medium.com/@benlesh/on-the-subject-of-subjects-in-rxjs-2b08b7198b93#.itwajvi1m
and so I agree that we should not trap the errors and be as verbose as possible when any exception is raised,

Angular 2 Kitchen sink: http://ng2.javascriptninja.io
and source@ https://github.com/born2net/Angular-kitchen-sink
Regards,

Sean

@born2net born2net changed the title feature: if no error function passed to subscribe, need to console.error feature: if no error function passed to subscribe, need to at least console.error Feb 12, 2017

@paulpdaniels

This comment has been minimized.

Copy link
Contributor

paulpdaniels commented Feb 13, 2017

Wrong repo. You want https://github.com/ReactiveX/rxjs

@born2net

This comment has been minimized.

Copy link
Author

born2net commented Feb 13, 2017

sorry tx!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.