New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug events #2833

Closed
RuiAAPeres opened this Issue Apr 27, 2016 · 3 comments

Comments

Projects
None yet
3 participants
@RuiAAPeres
Copy link
Member

RuiAAPeres commented Apr 27, 2016

RxSwift provides a quite handy mechanism for debugging events via the debug operator ( more info here). There is a resourceCount as well, that could be interesting, although I think it would force us to scatter some macros around the code base.

I am up for doing the debug(), but I would like your opinion on the resourceCount).

Thanks @scotteg for the reference!

@dmcrodrigues

This comment has been minimized.

Copy link
Contributor

dmcrodrigues commented Apr 27, 2016

This debug operator can be extremely handy, sometimes I do this manually to figure out what's going on which is not ideal to be honest.

Big 👍 to add this operator.

@dmcrodrigues

This comment has been minimized.

Copy link
Contributor

dmcrodrigues commented Apr 27, 2016

About resourceCount I think it can be helpful, probably using protocol extensions to introduce this behaviour in a meaningful way and internally use a swift flag to enable/disable this tracing. @jckarter has pointed here that empty functions may be optimized away by the compiler.

@mdiep

This comment has been minimized.

Copy link
Contributor

mdiep commented Apr 28, 2016

👍 for debug. In RAC2, this was called logAll. I think it's useful.

resourceCount doesn't seem as useful to me, and it adds quite a bit of complexity, so I'm 👎 on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment