Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a couple of issues I was able to trace back to
-flatten:
. This pull request fixes them.-flatten:
when it's used by-concat
. If the current subscription completes at the same time as a new signal is added, the new signal could be subscribed to immediately in addition to the queued up signal that was supposed to be subscribed to next.subscribeToSignal
wasn't being cleaned up.subscribeToSignal
being called after it had been set to nil.