New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add showsCancelButton, textDidBeginEditing and ...EndEditing to UISearchBar #3565

Merged
merged 3 commits into from Feb 1, 2018

Conversation

Projects
None yet
2 participants
@banjun
Copy link
Contributor

banjun commented Jan 24, 2018

I want to show/hide the cancel button of a UISearchBar when its focus changed, with mapping with some other app specific conditions.
With the missing textDidBeginEditing reactive extension, I can use ReactiveCocoa to bind all I need instead of using its delegate.

As UISearchBar is not a UITextField nor UIControl, other common extensions such as mapControlEvents cannot be used for that.

Checklist

  • Updated CHANGELOG.md.

banjun added some commits Jan 24, 2018

@mdiep

mdiep approved these changes Feb 1, 2018

@mdiep

This comment has been minimized.

Copy link
Contributor

mdiep commented Feb 1, 2018

This looks great! Well done! Thank you for writing tests.

@mdiep mdiep merged commit 55c1890 into ReactiveCocoa:master Feb 1, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@banjun banjun deleted the banjun:uisearchbar-focus-and-cancel branch Feb 1, 2018

@ra1028 ra1028 referenced this pull request Feb 25, 2018

Closed

Make CocoaTarget to public #3572

1 of 1 task complete

@banjun banjun referenced this pull request Apr 9, 2018

Merged

Correct CHANGELOG refs at 7.2.0 #3584

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment