Implement -respondsToSelector: when using -rac_signalForSelector: on KVO'd target #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -201,9 +235,13 @@ static Class RACSwizzleClass(NSObject *self) { | |||
| // Just swizzle -forwardInvocation: in-place. Since the object's class | |||
| // was almost certainly dynamically changed, we shouldn't see another of | |||
| // these classes in the hierarchy. | |||
| // | |||
| // Additionally, swizzle -respondsToSelector: becuase the default | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
😆 😂
Who knew that spelling because wrong could turn out to make my day.
|
🍰 |
|
🍨 |
|
Easy as 1-2-3, A-C-B. |
ghost
assigned 
| @@ -87,6 +87,40 @@ static void RACSwizzleForwardInvocation(Class class) { | |||
| class_replaceMethod(class, forwardInvocationSEL, imp_implementationWithBlock(newForwardInvocation), "v@:@"); | |||
| } | |||
|
|
|||
| static void RACSwizzleRespondsToSelector(Class class) { | |||
| @@ -201,9 +235,13 @@ static Class RACSwizzleClass(NSObject *self) { | |||
| // Just swizzle -forwardInvocation: in-place. Since the object's class | |||
| // was almost certainly dynamically changed, we shouldn't see another of | |||
| // these classes in the hierarchy. | |||
| // | |||
| // Additionally, swizzle -respondsToSelector: because the default | |||
| // implementation is ignorant of methods added to this class. | |||
There was a problem hiding this comment.
*may be ignorant (:trollface:?)
|
🎩 |
|
👓 |
|
😎 |
jspahrsummers
added a commit
that referenced
this pull request
Oct 28, 2013
Implement -respondsToSelector: when using -rac_signalForSelector: on KVO'd target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #889
When calling
-rac_signalForSelector:on an object that has been KVO'd, we implement the selector directly on KVO's dynamic subclass. However, the default implementation of-respondsToSelector:bases its result on the class returned by-class, which KVO overrides to return the original class, not its custom subclass.This change redefines
-respondsToSelector:when calling-rac_signalForSelector:on a target that has been KVO subclassed.