New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry(upTo:interval:on:) #496

Merged
merged 6 commits into from Aug 7, 2017

Conversation

Projects
None yet
4 participants
@tjnet
Contributor

tjnet commented Jul 24, 2017

Checklist

  • Updated CHANGELOG.md.

Summary

I implemented #224 and write test code

I'm new to this. Is this correct?
Please review in your free time.

@andersio andersio added the additive label Jul 25, 2017

var values: [Int] = []
var completed = false
original.retry(upTo: Int.max, interval: 1, on: scheduler)

This comment has been minimized.

@mdiep

mdiep Jul 25, 2017

Contributor

Please add a test that tests hitting the uptown limit.

@mdiep

mdiep Jul 25, 2017

Contributor

Please add a test that tests hitting the uptown limit.

This comment has been minimized.

@tjnet

tjnet Jul 25, 2017

Contributor

Thank you for your review so much! I 'll add test!

@tjnet

tjnet Jul 25, 2017

Contributor

Thank you for your review so much! I 'll add test!

This comment has been minimized.

@tjnet
@tjnet
Show outdated Hide outdated Tests/ReactiveSwiftTests/SignalProducerSpec.swift
Show outdated Hide outdated Tests/ReactiveSwiftTests/SignalProducerSpec.swift
@mdiep

This comment has been minimized.

Show comment
Hide comment
@mdiep

mdiep Jul 25, 2017

Contributor

Thanks for opening a PR!

Contributor

mdiep commented Jul 25, 2017

Thanks for opening a PR!

@tjnet

This comment has been minimized.

Show comment
Hide comment
@tjnet

tjnet Jul 29, 2017

Contributor

I updated pull request. Any thoughts?
Please review in your free time.

Contributor

tjnet commented Jul 29, 2017

I updated pull request. Any thoughts?
Please review in your free time.

@mdiep

Please add this to the CHANGELOG as well!

@mdiep

mdiep approved these changes Aug 7, 2017

@mdiep

This comment has been minimized.

Show comment
Hide comment
@mdiep

mdiep Aug 7, 2017

Contributor

Thanks for the PR! Sorry I've been slow reviewing. It's been a busy few weeks.

The Swift 4 linux build failed, but I think that's because it needs to be updated.

Contributor

mdiep commented Aug 7, 2017

Thanks for the PR! Sorry I've been slow reviewing. It's been a busy few weeks.

The Swift 4 linux build failed, but I think that's because it needs to be updated.

@mdiep mdiep merged commit 4c0e12b into ReactiveCocoa:master Aug 7, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details

@tjnet tjnet deleted the tjnet:deferred_retry_from_rex branch Aug 15, 2017

@tjnet

This comment has been minimized.

Show comment
Hide comment
@tjnet

tjnet Aug 15, 2017

Contributor

Sorry for my late reply.. I deeply appreciate your review and feedback! 😄

Contributor

tjnet commented Aug 15, 2017

Sorry for my late reply.. I deeply appreciate your review and feedback! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment