Skip to content

[gardening] Use _SimpleDisposable in AnyDisposable #510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2017
Merged

[gardening] Use _SimpleDisposable in AnyDisposable #510

merged 1 commit into from
Sep 7, 2017

Conversation

@ikesyo
Copy link
Member

@ikesyo ikesyo commented Sep 7, 2017

Checklist

  • [ ] Updated CHANGELOG.md.

andersio
andersio requested changes Sep 7, 2017
View reviewed changes
Copy link
Member

@andersio andersio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that ‘_SimpleDisposablehas duped the privateActionDisposable. Could we remove SimpleDisposable& promote that tointernal` instead?

@ikesyo ikesyo merged commit 3e2b194 into master Sep 7, 2017
@ikesyo ikesyo deleted the simpledisposable-in-anydisposable branch September 7, 2017 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mdiep mdiep mdiep approved these changes

@andersio andersio andersio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ikesyo @mdiep @andersio