Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Quick to 2.0.0 and Nimble to 8.0.0 #711

Merged
merged 3 commits into from Mar 7, 2019

Conversation

Projects
None yet
3 participants
@ikesyo
Copy link
Member

commented Mar 3, 2019

This is required to build using Xcode 10.2. But we require Swift 4.2 at least now, so we must drop Swift 4.1 support.

Checklist

  • [ ] Updated CHANGELOG.md.
@mdiep

mdiep approved these changes Mar 3, 2019

@mdiep

This comment has been minimized.

Copy link
Contributor

commented Mar 3, 2019

I think the deployment target of the macOS tests will need to be changed to 10.10 to match Quick/Nimble.

@ikesyo ikesyo referenced this pull request Mar 3, 2019

Merged

[BREAKING] Drop Swift 4.1 support #712

0 of 1 task complete
@andersio

This comment has been minimized.

Copy link
Member

commented Mar 3, 2019

CI for Xcode 9.4 can be removed.

@ikesyo ikesyo force-pushed the update-quick-and-nimble branch 2 times, most recently from 99f1ffc to f2f5e5e Mar 4, 2019

@@ -1278,7 +1278,7 @@
CURRENT_PROJECT_VERSION = 1;
ENABLE_TESTABILITY = YES;
IPHONEOS_DEPLOYMENT_TARGET = 8.0;
MACOSX_DEPLOYMENT_TARGET = 10.9;
MACOSX_DEPLOYMENT_TARGET = 10.10;

This comment has been minimized.

Copy link
@mdiep

mdiep Mar 7, 2019

Contributor

Can we update the deployment target of just the test target and leave the framework's deployment target at 10.9?

This comment has been minimized.

Copy link
@ikesyo

ikesyo Mar 7, 2019

Author Member

I'll address that.

This comment has been minimized.

Copy link
@ikesyo

ikesyo Mar 7, 2019

Author Member

Fixed in 8bdcc81.

@ikesyo ikesyo force-pushed the update-quick-and-nimble branch from f2f5e5e to 595a1ba Mar 7, 2019

@mdiep

mdiep approved these changes Mar 7, 2019

@mdiep mdiep merged commit a6cc1d0 into master Mar 7, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mdiep mdiep deleted the update-quick-and-nimble branch Mar 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.