Update Quick to 2.0.0 and Nimble to 8.0.0 #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdiep
approved these changes
Mar 3, 2019
|
I think the deployment target of the macOS tests will need to be changed to 10.10 to match Quick/Nimble. |
andersio
approved these changes
Mar 3, 2019
|
CI for Xcode 9.4 can be removed. |
ikesyo
force-pushed
the
update-quick-and-nimble
branch
2 times, most recently
from
99f1ffc
to
f2f5e5e
Compare
mdiep
reviewed
Mar 7, 2019
| @@ -1278,7 +1278,7 @@ | |||
| CURRENT_PROJECT_VERSION = 1; | |||
| ENABLE_TESTABILITY = YES; | |||
| IPHONEOS_DEPLOYMENT_TARGET = 8.0; | |||
| MACOSX_DEPLOYMENT_TARGET = 10.9; | |||
| MACOSX_DEPLOYMENT_TARGET = 10.10; | |||
There was a problem hiding this comment.
Can we update the deployment target of just the test target and leave the framework's deployment target at 10.9?
ikesyo
force-pushed
the
update-quick-and-nimble
branch
from
f2f5e5e
to
595a1ba
Compare
mdiep
approved these changes
Mar 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to build using Xcode 10.2. But we require Swift 4.2 at least now, so we must drop Swift 4.1 support.
Checklist
[ ] Updated CHANGELOG.md.