Build pipeline broken

[dariomannu]

The current build pipeline is broken. Is that just a matter of upgrading Node and/or the JSON imports?

Run npm run build
  npm run build
  shell: /usr/bin/bash -e {0}

> rimmel@1.5.2 build
> rimraf dist && rollup --config rollup.config.js

[!] TypeError: Module "file:///home/runner/work/rimmel/rimmel/tsconfig.json" needs an import attribute of "type: json"
    at validateAttributes (node:internal/modules/esm/assert:88:15)
    at defaultLoad (node:internal/modules/esm/load:105:3)
    at ModuleLoader.load (node:internal/modules/esm/loader:801:12)
    at ModuleLoader.loadAndTranslate (node:internal/modules/esm/loader:586:43)
    at ModuleLoader.#createModuleJob (node:internal/modules/esm/loader:610:36)
    at ModuleLoader.#getJobFromResolveResult (node:internal/modules/esm/loader:341:34)
    at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:309:41)
    at onImport.tracePromise.__proto__ (node:internal/modules/esm/loader:650:25)


Error: Process completed with exit code 1.

[vansh2408]

@dariomannu The error "needs an import attribute of type: json" occurs when you try to use an ECMAScript import statement for a JSON file in a module-based Node.js environment. The Node.js runtime requires an explicit with { type: 'json' } attribute to ensure type safety and proper handling of the JSON file

[RIYAKUMARI001]

@vansh2408 Spot on about the with { type: 'json' } syntax! You're absolutely right about the modern import approach.

@dariomannu Hey!I ran into this exact same issue and actually have a working fix. The problem is that newer Node.js versions are stricter about JSON imports, plus there's another issue - the current code tries to modify the imported JSON object which becomes read-only.

Here's what I found works best - instead of dealing with import syntax complications, just use good old synchronous file reading. It's actually cleaner for build scripts:

import { readFileSync } from 'fs';
import { nodeResolve } from '@rollup/plugin-node-resolve';
import json from '@rollup/plugin-json';
import { join } from 'path';
import typescript from '@rollup/plugin-typescript';
import { visualizer } from 'rollup-plugin-visualizer';

const getTSConfig = (path) => {
const tsConfig = JSON.parse(readFileSync('./tsconfig.json', 'utf8'));
tsConfig.compilerOptions.outDir = path;
tsConfig.compilerOptions.declarationDir = join(path, 'types');
return tsConfig.compilerOptions;
};

export default [
{ // Global JS
external: ['rxjs'],
input: './src/index.ts',
treeshake: {
propertyReadSideEffects: false,
},
plugins: [
nodeResolve({ preferBuiltins: true }),
typescript({
getTSConfig('dist/globaljs'),
sourceMap: true,
outDir: 'dist/globaljs',
declaration: false,
declarationDir: undefined,
declarationMap: false,
}),
visualizer({ filename: 'bundle-stats-globaljs.html' }),
],
// ... rest of config
},
// ... other configs with getTSConfig('dist/esm') and getTSConfig('dist/ssr')
];

[dariomannu]

Don't trust the chatbots too easily. Always challenge them until you squeeze the last drop of truth out.

import tsConfig from './tsconfig.json' with { type: 'json' };

[dariomannu]

fixed, upgraded node, changed import syntax