Use Android build system, generate AARs #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| minSdkVersion rootProject.ext.minSdkVersion | ||
| targetSdkVersion rootProject.ext.targetSdkVersion | ||
| versionCode 1 | ||
| versionName "1.0" |
There was a problem hiding this comment.
versionName value can be set with single quotes '1.0' (saves some nanoseconds on string parsing -> faster build 😄)
Also updated to latest & greatest dependencies while I was at it.
dlew
force-pushed
the
dlew/android-plugin-builds
branch
from
863923d
to
32ae9fc
Compare
|
👍 for Android Studio support, probably you also need to add androidJavadoc and androidSources tasks here or in separate PR, because now they are not generated, as far as I see. |
|
I opened this in Android Studio 1.3 Beta 1. I had the SDK tools fully updated and the m2 repos set up as I would normally. Sample runs, and project builds. It would be nice if a named aar was created instead of the default 👍 |
JakeWharton
added a commit
that referenced
this pull request
Jun 30, 2015
Use Android build system, generate AARs
|
The files get named appropriately by default: |
This was referenced Jun 30, 2015
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updated to latest & greatest dependencies while I was at it.
This PR gets rid of gradle-rxjava-project-plugin because it's incompatible with the Android build plugins. It's actually a smorgasbord of plugins, some of which seem to be geared only towards the Java plugin.
I think we'll end up having to import the individual plugins as necessary for release. I'm thinking we can handle that in parallel with other development; having this library work easily in Android Studio should really help out development.