Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6195 Fix Flowable.reduce(BiFunction) JavaDoc #6197

Merged
merged 1 commit into from Sep 3, 2018

Conversation

@ylecaillez
Copy link
Contributor

commented Sep 3, 2018

Empty source does not signal NoSuchElementException.

Resolves #6195

Empty source does not signal NoSuchElementException.
@akarnokd akarnokd added this to the 2.2 backlog milestone Sep 3, 2018
@codecov

This comment has been minimized.

Copy link

commented Sep 3, 2018

Codecov Report

Merging #6197 into 2.x will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #6197      +/-   ##
============================================
+ Coverage     98.22%   98.24%   +0.01%     
- Complexity     6197     6205       +8     
============================================
  Files           667      667              
  Lines         44888    44888              
  Branches       6218     6218              
============================================
+ Hits          44091    44099       +8     
+ Misses          253      249       -4     
+ Partials        544      540       -4
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Flowable.java 100% <ø> (ø) 566 <0> (ø) ⬇️
...l/operators/observable/ObservableFlatMapMaybe.java 90.84% <0%> (-5.23%) 2% <0%> (ø)
...ternal/operators/observable/ObservablePublish.java 96.46% <0%> (-3.54%) 11% <0%> (ø)
...rnal/operators/flowable/FlowableSkipLastTimed.java 95.91% <0%> (-2.05%) 2% <0%> (ø)
...nternal/operators/observable/ObservableWindow.java 98% <0%> (-2%) 3% <0%> (ø)
...perators/mixed/ObservableSwitchMapCompletable.java 98.94% <0%> (-1.06%) 3% <0%> (ø)
...ernal/operators/flowable/FlowableFlatMapMaybe.java 92.75% <0%> (-0.97%) 2% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 97.43% <0%> (-0.86%) 2% <0%> (ø)
.../operators/maybe/MaybeFlatMapIterableFlowable.java 97.54% <0%> (-0.82%) 2% <0%> (ø)
...ex/internal/operators/flowable/FlowableCreate.java 97.41% <0%> (-0.33%) 6% <0%> (ø)
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7d91c6...d2f1ca3. Read the comment docs.

@akarnokd akarnokd merged commit 205fea6 into ReactiveX:2.x Sep 3, 2018
3 checks passed
3 checks passed
codecov/patch Coverage not affected when comparing c7d91c6...d2f1ca3
Details
codecov/project 98.24% (target 95%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.