Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme: Cherry-pick fixes from #6683, add ProGuard workaround entry #6699

Merged
merged 1 commit into from Nov 4, 2019

Conversation

@akarnokd
Copy link
Member

akarnokd commented Nov 1, 2019

  • Pick the accepted changes from #6683.
  • Add entry about ProGuard and Reactive Streams JAR warning issue.
@akarnokd akarnokd added this to the 3.0 milestone Nov 1, 2019
@akarnokd akarnokd referenced this pull request Nov 1, 2019
0 of 3 tasks complete
@akarnokd akarnokd changed the title Cherry-pick fixes from #6683, add ProGuard workaround entry Readme: Cherry-pick fixes from #6683, add ProGuard workaround entry Nov 1, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 1, 2019

Codecov Report

Merging #6699 into 3.x will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6699      +/-   ##
============================================
+ Coverage     98.12%   98.19%   +0.06%     
- Complexity     6189     6190       +1     
============================================
  Files           677      677              
  Lines         44657    44657              
  Branches       6170     6170              
============================================
+ Hits          43821    43852      +31     
+ Misses          300      287      -13     
+ Partials        536      518      -18
Impacted Files Coverage Δ Complexity Δ
.../operators/observable/ObservableFlatMapSingle.java 90.47% <0%> (-4.77%) 2% <0%> (ø)
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...ternal/operators/observable/ObservableGroupBy.java 95.08% <0%> (-0.55%) 2% <0%> (ø)
...rxjava3/internal/schedulers/ExecutorScheduler.java 97% <0%> (-0.5%) 10% <0%> (ø)
...a3/internal/operators/flowable/FlowableCreate.java 97.41% <0%> (-0.33%) 6% <0%> (ø)
...ternal/operators/flowable/FlowableWindowTimed.java 93.02% <0%> (+0.23%) 4% <0%> (ø) ⬇️
...3/internal/operators/flowable/FlowableGroupBy.java 96.28% <0%> (+0.26%) 3% <0%> (ø) ⬇️
...va3/internal/operators/parallel/ParallelRunOn.java 97.1% <0%> (+0.48%) 8% <0%> (ø) ⬇️
...ernal/operators/flowable/FlowableFlatMapMaybe.java 93.75% <0%> (+0.52%) 2% <0%> (ø) ⬇️
...nternal/operators/observable/ObservableCreate.java 99.14% <0%> (+0.85%) 2% <0%> (ø) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b9727da...e473785. Read the comment docs.

@akarnokd akarnokd merged commit 5f283f0 into 3.x Nov 4, 2019
4 checks passed
4 checks passed
codecov/patch Coverage not affected when comparing b9727da...e473785
Details
codecov/project 98.19% (target 95%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@akarnokd akarnokd deleted the akarnokd-patch-1 branch Nov 4, 2019
Copy link
Contributor

vanniktech left a comment

@akarnokd

This comment has been minimized.

Copy link
Member Author

akarnokd commented Nov 4, 2019

If I understand #6698, the issue was disabling R8, which had no problems to begin with, and the default ProGuard complaining. Looks like this embed would work only with R8.

@vanniktech

This comment has been minimized.

Copy link
Contributor

vanniktech commented Nov 4, 2019

AFAIK, this only does work for R8 yes. Would still be super beneficial as it's the default shrinker for Android.

@akarnokd

This comment has been minimized.

Copy link
Member Author

akarnokd commented Nov 4, 2019

Does R8 even complain without those -dontwarn entries?

@vanniktech

This comment has been minimized.

Copy link
Contributor

vanniktech commented Nov 4, 2019

I haven't built a release version with the latest RxJava version. If I do, and I see those warnings, I'll come back to this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.