Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Add Completable.onErrorResumeWith #6868

Merged
merged 1 commit into from
Jan 24, 2020

Conversation

akarnokd
Copy link
Member

This PR adds the missing Completable.onErrorResumeWith present in the rest of the base classes.

Also marbles for Maybe.onErrorResumeNext and Maybe.onErrorResumeWith have been updated.

Related #6852, #5806

image
image
image

@codecov
Copy link

codecov bot commented Jan 24, 2020

Codecov Report

Merging #6868 into 3.x will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #6868      +/-   ##
============================================
+ Coverage     98.28%   98.31%   +0.02%     
- Complexity     6429     6432       +3     
============================================
  Files           719      719              
  Lines         46744    46746       +2     
  Branches       6401     6401              
============================================
+ Hits          45944    45958      +14     
+ Misses          283      278       -5     
+ Partials        517      510       -7
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/rxjava3/core/Maybe.java 100% <ø> (ø) 185 <0> (ø) ⬇️
...in/java/io/reactivex/rxjava3/core/Completable.java 100% <100%> (ø) 125 <1> (+1) ⬆️
...l/operators/observable/ObservableFlatMapMaybe.java 83.8% <0%> (-11.98%) 2% <0%> (ø)
.../operators/flowable/FlowableBlockingSubscribe.java 93.02% <0%> (-4.66%) 10% <0%> (-1%)
...tivex/rxjava3/disposables/CompositeDisposable.java 98.14% <0%> (-1.86%) 39% <0%> (-1%)
...rnal/operators/observable/ObservableSwitchMap.java 91.57% <0%> (-1.06%) 3% <0%> (ø)
...nternal/operators/observable/ObservableCreate.java 97.43% <0%> (-0.86%) 2% <0%> (ø)
...perators/single/SingleFlatMapIterableFlowable.java 95.83% <0%> (-0.84%) 2% <0%> (ø)
...al/operators/observable/ObservableWindowTimed.java 96.12% <0%> (-0.65%) 4% <0%> (ø)
...3/internal/operators/flowable/FlowableGroupBy.java 95.59% <0%> (-0.63%) 3% <0%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad1840b...0ad2a1e. Read the comment docs.

@akarnokd akarnokd merged commit b157b86 into ReactiveX:3.x Jan 24, 2020
@akarnokd akarnokd deleted the CompletableOnErrorResumeWith3x branch January 24, 2020 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant