Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.x: Improve Javadocs of Connectable sources #7127

Merged
merged 1 commit into from Dec 7, 2020

Conversation

akarnokd
Copy link
Member

@akarnokd akarnokd commented Dec 7, 2020

Improve the styling and wording of ConnectableObservable and ConnectableFlowable.

@codecov
Copy link

codecov bot commented Dec 7, 2020

Codecov Report

Merging #7127 (886f791) into 3.x (7e7b223) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##                3.x    #7127      +/-   ##
============================================
- Coverage     99.54%   99.53%   -0.02%     
  Complexity     6674     6674              
============================================
  Files           742      742              
  Lines         47273    47273              
  Branches       6376     6376              
============================================
- Hits          47060    47052       -8     
- Misses           98      100       +2     
- Partials        115      121       +6     
Impacted Files Coverage Δ Complexity Δ
...activex/rxjava3/flowables/ConnectableFlowable.java 100.00% <ø> (ø) 12.00 <0.00> (ø)
...vex/rxjava3/observables/ConnectableObservable.java 100.00% <100.00%> (ø) 12.00 <4.00> (ø)
...l/operators/observable/ObservableFlatMapMaybe.java 91.54% <0.00%> (-7.05%) 2.00% <0.00%> (ø%)
...erators/completable/CompletableConcatIterable.java 95.91% <0.00%> (-4.09%) 2.00% <0.00%> (ø%)
...x/rxjava3/internal/operators/single/SingleAmb.java 96.61% <0.00%> (-3.39%) 9.00% <0.00%> (-1.00%)
...vex/rxjava3/internal/operators/maybe/MaybeAmb.java 96.96% <0.00%> (-3.04%) 10.00% <0.00%> (-1.00%)
...eactivex/rxjava3/processors/BehaviorProcessor.java 97.48% <0.00%> (-2.52%) 50.00% <0.00%> (ø%)
...nternal/operators/observable/ObservableWindow.java 98.21% <0.00%> (-1.79%) 3.00% <0.00%> (ø%)
.../operators/observable/ObservableFlatMapSingle.java 94.44% <0.00%> (-1.59%) 2.00% <0.00%> (ø%)
...ternal/operators/completable/CompletableMerge.java 97.29% <0.00%> (-1.36%) 2.00% <0.00%> (ø%)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e7b223...886f791. Read the comment docs.

@akarnokd akarnokd merged commit c573219 into ReactiveX:3.x Dec 7, 2020
@akarnokd akarnokd deleted the ConnectableDocCleanup3x branch December 7, 2020 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants