Fixed client connection level events #527

Merged
merged 1 commit into from Jul 5, 2016

Conversation

Projects
None yet
1 participant
@NiteshKant
Member

NiteshKant commented Jul 5, 2016

Problem

Since the pipelines for client are setup after the connection is established, callbacks like connect are not send to the handlers. This was the reason for missing the connection related events for clients.
PooledConnection acquire events were not published because the events were getting published before the event listeners were setup.

Modification

This change moves the work done for client on ChannelHandler.connet() to ChannelActivityBufferingHandler which is added on channel creation.

Now, publishing events for pool acquire are published using the event publisher configured on the channel.

Fixed client connection level events
#### Problem

Since the pipelines for client are setup after the connection is established, callbacks like `connect` are not send to the handlers. This was the reason for missing the connection related events for clients.
`PooledConnection` acquire events were not published because the events were getting published before the event listeners were setup.

#### Modification

This change moves the work done for client on `ChannelHandler.connet()` to `ChannelActivityBufferingHandler` which is added on channel creation.

Now, publishing events for pool acquire are published using the event publisher configured on the channel.

@NiteshKant NiteshKant added this to the 0.5.2-rc.4 milestone Jul 5, 2016

@NiteshKant NiteshKant merged commit 1249344 into ReactiveX:0.5.x Jul 5, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@NiteshKant NiteshKant deleted the NiteshKant:conn-events-fix branch Jul 5, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment