Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix sometimes empty response. #613
Sometimes the response will be accidentally empty.
Moving the onNext event into the synchronized block fixes the problem.
Also added a test that without is flaky without my fix
jamesgorman2 left a comment
Thanks Jonas, LGTM.
Synchronised sequencing looks right. There's probably a less blocking (and more complicated) approach like in the canonical RxJava examples but I don't think they bring enough benefit to warrant putting them in.