Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interval instead of timer for the idleConnectionCleanup #615

Merged
merged 4 commits into from Feb 14, 2019

Conversation

Projects
None yet
3 participants
@rassmate
Copy link

rassmate commented Jan 22, 2019

Using interval instead of timer for the idleConnectionCleanup because the interval will tick many times every specified millisecond and timer will only tick once and then complete and I guess that is not what we want

Jonas Fredin added some commits Jan 22, 2019

Jonas Fredin
using interval instead of timer in idleConnectionCleanupTicker
Timer will only tick once and then complete.
Interval will tick once every specified millisecond.
@rassmate

This comment has been minimized.

Copy link
Author

rassmate commented Feb 12, 2019

And this as well @jamesgorman2

@jamesgorman2
Copy link
Collaborator

jamesgorman2 left a comment

@rassmate could you have a look at my comment and have a think, if I'm wrong we're good to go on this, otherwise can you make the change and we'll get this merged

@rassmate

This comment has been minimized.

Copy link
Author

rassmate commented Feb 13, 2019

Jonas Fredin
@jamesgorman2
Copy link
Collaborator

jamesgorman2 left a comment

Sorry, something I missed the first time around. Small fix.
Also just confirmed expected behaviour of the retry in a scratch test.

@rassmate

This comment has been minimized.

Copy link
Author

rassmate commented Feb 14, 2019

@jamesgorman2
Copy link
Collaborator

jamesgorman2 left a comment

LGTM

@jamesgorman2 jamesgorman2 merged commit a7ca9a9 into ReactiveX:0.5.x Feb 14, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jamesgorman2

This comment has been minimized.

Copy link
Collaborator

jamesgorman2 commented Feb 14, 2019

Thanks Jonas, now rc is in flight.

@rassmate

This comment has been minimized.

Copy link
Author

rassmate commented Feb 14, 2019

No problem! Our production servers feels a lot better with these fixes in place.
Thanks for the attention. @jamesgorman2

@rassmate

This comment has been minimized.

Copy link
Author

rassmate commented Feb 15, 2019

@jamesgorman2 any non rc release of this anytime soon?

@jamesgorman2

This comment has been minimized.

Copy link
Collaborator

jamesgorman2 commented Feb 18, 2019

Just pushed out 0.5.3 with the last batch of changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.