Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reroute exceptions in onNext to onError by default #193

Merged
merged 2 commits into from Oct 26, 2017

Conversation

@mbonneau
Copy link
Member

commented Oct 26, 2017

Fixes #192

This PR catches exceptions in onNext in the default observer that is created when you call subscribe using callbacks and sends them to the onError handler.

This resolves issues with errors and exceptions happening in a completely silent way.

This may not resolve silent failures if you do not have a handler for the error. This can be dealt with in a separate PR after that warns if you do not pass in an onError and an error occurs.

This is specifically only applied to the default observer that is built in subscribe. If the user sends in their own Observer the library leaves handling these issues up to the user.

@mbonneau mbonneau requested a review from davidwdan Oct 26, 2017
@coveralls

This comment has been minimized.

Copy link

commented Oct 26, 2017

Coverage Status

Coverage increased (+0.003%) to 99.4% when pulling 537deec on mbonneau:reroute-exceptions into a5d7c1e on ReactiveX:master.

@davidwdan davidwdan merged commit b7ba556 into ReactiveX:master Oct 26, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.