Permalink
Browse files

Reverts architecture check.

  • Loading branch information...
kzaher committed Sep 20, 2018
1 parent a582064 commit 0df62b4d562f8620d4b795b18e4adf0b631527a1
Showing with 1 addition and 10 deletions.
  1. +0 −1 CHANGELOG.md
  2. +1 −9 RxCocoa/Foundation/KVORepresentable+CoreGraphics.swift
View
@@ -8,7 +8,6 @@ All notable changes to this project will be documented in this file.
#### Anomalies
* Fixes the warning for arm64_32 architecture (watchOS 5) in RxCocoa for Swift versions priror to 4.2.
* Fixes issues with CocoaPods and Swift 4.2 version.
## [4.3.0](https://github.com/ReactiveX/RxSwift/releases/tag/4.3.0)
@@ -17,18 +17,10 @@ import class Foundation.NSValue
let CGRectType = "{CGRect={CGPoint=dd}{CGSize=dd}}"
let CGSizeType = "{CGSize=dd}"
let CGPointType = "{CGPoint=dd}"
#elseif arch(i386) || arch(arm)
#elseif arch(i386) || arch(arm) || arch(arm64_32)
let CGRectType = "{CGRect={CGPoint=ff}{CGSize=ff}}"
let CGSizeType = "{CGSize=ff}"
let CGPointType = "{CGPoint=ff}"
#else
#if swift(>=4.2)
#if arch(arm64_32)
let CGRectType = "{CGRect={CGPoint=ff}{CGSize=ff}}"
let CGSizeType = "{CGSize=ff}"
let CGPointType = "{CGPoint=ff}"
#endif
#endif
#endif
extension CGRect : KVORepresentable {

3 comments on commit 0df62b4

@freak4pc

This comment has been minimized.

Show comment
Hide comment
@freak4pc

freak4pc Sep 22, 2018

Collaborator

Wouldn't this reversion mean it can't build for watchOS 5 anymore? (which means also for iOS targets that have watchOS companions, possibly?)

Collaborator

freak4pc replied Sep 22, 2018

Wouldn't this reversion mean it can't build for watchOS 5 anymore? (which means also for iOS targets that have watchOS companions, possibly?)

@radex

This comment has been minimized.

Show comment
Hide comment
@radex

radex Sep 25, 2018

Contributor

@freak4pc looks more like a refactoring, not a revert. Unless I'm missing something, the changed code does the same thing

Contributor

radex replied Sep 25, 2018

@freak4pc looks more like a refactoring, not a revert. Unless I'm missing something, the changed code does the same thing

@freak4pc

This comment has been minimized.

Show comment
Hide comment
@freak4pc

freak4pc Sep 25, 2018

Collaborator

Oh it reverted to my original commit, sorry, misread :)

Collaborator

freak4pc replied Sep 25, 2018

Oh it reverted to my original commit, sorry, misread :)

Please sign in to comment.