Permalink
Browse files

Adding build trigger only for master and develop (#1823)

  • Loading branch information...
LucianoPAlmeida authored and freak4pc committed Dec 12, 2018
1 parent e74a679 commit c8a1420ef29ca6d796d81f825344a72e9fb1ac22
Showing with 6 additions and 0 deletions.
  1. +6 −0 .travis.yml
@@ -7,6 +7,12 @@ language: generic
sudo: required
dist: trusty
osx_image: xcode9.3

branches:
only:
- master
- develop

This comment has been minimized.

@kzaher

kzaher Dec 26, 2018

Member

Hi @LucianoPAlmeida @freak4pc ,

Could somebody please explain what problem does this solve?

I've seen something about double builds but it is not clear to me who was bothered by them and when did they happen and we don't want them to happen?

This disables travis for branches I'm working on or experimenting which is something that creates issues for me.

This comment has been minimized.

@LucianoPAlmeida

LucianoPAlmeida Dec 27, 2018

Contributor

Hey @kzaher
Travis was triggering two builds redundant (one for push and other for pr) every time somebody opened a pr from an arbitrary branch created on origin. I was facing this issue on another project (more details here) and when a spotted this here too, I thought could be a nice thing to remove this redundancy.
This is not a problem really but sometimes was annoying on the other project because build took twice the time just to build the same thing.
Sorry didn't know it was being used. I can send a PR to revert it :))

This comment has been minimized.

@LucianoPAlmeida

LucianoPAlmeida Dec 27, 2018

Contributor

Reverting is in #1838 :))

This comment has been minimized.

@freak4pc

freak4pc Dec 27, 2018

Collaborator

The “bother” it creates is waiting for two builds that do the same while it is also locking builds for other PRs if there are more than one. In any way didn’t consider you working on side branches this way - could be solved with a manual trigger but I guess that’s a hassle.

Could there be a way to disable just “PR” ? So it always does only the “push” build like today ?

This comment has been minimized.

@kzaher

kzaher Dec 27, 2018

Member

I’m think that being polite is awesome, but It seems to me that the current solution is too restrictive.

I will for now add additional branch called fixes that will allow me to run travis on push, but I think that we would want to find a better solution.

I’m also unsure does this kill running travis for tags?

This comment has been minimized.

@LucianoPAlmeida

LucianoPAlmeida Dec 27, 2018

Contributor

Hey @kzaher @freak4pc :)

I’m think that being polite is awesome, but It seems to me that the current solution is too restrictive.

Considering the current workflow it is in fact

I’m also unsure does this kill running travis for tags?

not sure, but I think it does

My thoughts on that are: if it is something that is blocking or causing issues in the current workflow and doesn't have much impact because only a few people create PR from branches in origin, most of them are from forks.
It is better to revert it and then find another less restrictive solution while not causing issues on the workflow now.

At the end of the day, maybe this is a thing that should be done by Travis, it should be smart enough to notice that two builds are triggered on the same commit at the same time when a PR is open.


env:
- DANGER=1
- TEST=iOS

0 comments on commit c8a1420

Please sign in to comment.