New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[POC] Single + Maybe + Completeable #1123

Merged
merged 10 commits into from Mar 12, 2017

Conversation

Projects
None yet
5 participants
@kzaher
Member

kzaher commented Mar 6, 2017

I'm playing with proof of concept for Single/Maybe/Completeable units from RxJava.

If somebody has more experience with RxJava it would be great to get some confirmations.
I think this should be more or less it, but ¯\_(ツ)_/¯ .

I don't think we'll be able to support all operators from those units from RxJava, but it seems to me like a really cheap and generic way to provide those units in RxSwift by using existing operators.

If somebody has a better idea how to do this, please share.

@kzaher kzaher changed the base branch from master to develop Mar 6, 2017

@RxPullRequestBot

This comment has been minimized.

Show comment
Hide comment
@RxPullRequestBot

RxPullRequestBot Mar 6, 2017

        2 Warnings
    
  </th>
 </tr>
⚠️ No CHANGELOG changes made
⚠️ Big PR

Generated by 🚫 danger

RxPullRequestBot commented Mar 6, 2017

        2 Warnings
    
  </th>
 </tr>
⚠️ No CHANGELOG changes made
⚠️ Big PR

Generated by 🚫 danger

kzaher added some commits Mar 11, 2017

@AliSoftware

This comment has been minimized.

Show comment
Hide comment
@AliSoftware

AliSoftware Mar 12, 2017

Contributor

These new units might deserve adding a paragraph in https://github.com/ReactiveX/RxSwift/blob/master/Documentation/Units.md 😉

Contributor

AliSoftware commented Mar 12, 2017

These new units might deserve adding a paragraph in https://github.com/ReactiveX/RxSwift/blob/master/Documentation/Units.md 😉

@kzaher

This comment has been minimized.

Show comment
Hide comment
@kzaher

kzaher Mar 12, 2017

Member

@AliSoftware thnx for reminding, will add.

Member

kzaher commented Mar 12, 2017

@AliSoftware thnx for reminding, will add.

kzaher added some commits Mar 12, 2017

Adds `PrimitiveSequence` operators: `observeOn`. `ObservableType` ope…
…rators: `asSingle`, `asMaybe`, `asCompleteable`.

@kzaher kzaher merged commit beb62d7 into develop Mar 12, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@hzsweers

This comment has been minimized.

Show comment
Hide comment
@hzsweers

hzsweers Mar 13, 2017

Completeable is spelled differently than RxJava's Completable. Any reason for that?

hzsweers commented Mar 13, 2017

Completeable is spelled differently than RxJava's Completable. Any reason for that?

@kzaher kzaher deleted the poc/single,maybe,completeable branch Apr 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment