New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add NSScrollView.rx.backgroundColor #1270

Closed
wants to merge 1 commit into
base: develop
from

Conversation

Projects
None yet
3 participants
@DivineDominion
Contributor

DivineDominion commented May 26, 2017

I am just getting my feet wet providing macOS reactive extensions. The test succeeds, but feedback on the approach is very welcome so I know what to look for with other controls.

@RxPullRequestBot

This comment has been minimized.

Show comment
Hide comment
@RxPullRequestBot

RxPullRequestBot May 26, 2017

1 Warning
⚠️ No CHANGELOG changes made

Generated by 🚫 Danger

RxPullRequestBot commented May 26, 2017

1 Warning
⚠️ No CHANGELOG changes made

Generated by 🚫 Danger

@kzaher

This comment has been minimized.

Show comment
Hide comment
@kzaher

kzaher May 31, 2017

Member

Hi @DivineDominion ,

It doesn't seem to me that interface is made for observing. Maybe KVO will work, but in general it doesn't seem to me it should be used this way.

Member

kzaher commented May 31, 2017

Hi @DivineDominion ,

It doesn't seem to me that interface is made for observing. Maybe KVO will work, but in general it doesn't seem to me it should be used this way.

@DivineDominion

This comment has been minimized.

Show comment
Hide comment
@DivineDominion

DivineDominion Jun 1, 2017

Contributor

Oh, okay. Can you explain why a bit? -- I can imagine something among this: a Sink would work to consume changes, but since the scroll view doesn't update its color on its own, providing an Observable is not a good choice.

Contributor

DivineDominion commented Jun 1, 2017

Oh, okay. Can you explain why a bit? -- I can imagine something among this: a Sink would work to consume changes, but since the scroll view doesn't update its color on its own, providing an Observable is not a good choice.

@kzaher

This comment has been minimized.

Show comment
Hide comment
@kzaher

kzaher Jun 13, 2017

Member

Hi @DivineDominion ,

it just follows from my own personal experience regarding how to do unidirectional architectures.

You are allowed to bind to any UI property (bindings are just optimized view renderings for stateful UIs), but you are only allowed to observe direct user interaction events and convert them into commands that mutate the state.

Otherwise you are storing model inside the UI, which is ok if you are writing a "model" for UIControl, but not ok if you are writing you business logic.

Member

kzaher commented Jun 13, 2017

Hi @DivineDominion ,

it just follows from my own personal experience regarding how to do unidirectional architectures.

You are allowed to bind to any UI property (bindings are just optimized view renderings for stateful UIs), but you are only allowed to observe direct user interaction events and convert them into commands that mutate the state.

Otherwise you are storing model inside the UI, which is ok if you are writing a "model" for UIControl, but not ok if you are writing you business logic.

@kzaher kzaher closed this Jun 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment