Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hooks documentation, remove unexpected logs #1988

Merged
merged 1 commit into from Jun 3, 2019

Conversation

@MortyMerr
Copy link
Contributor

commented May 23, 2019

Hooks enum encapsulates quite useful logic for error handling/debugging, however, I didn't find any documentation about that. I am sure this enum could help users with debugging their apps, so my proposal is to add a description of it to GettingStarted.md

Also, I add check on empty array. If the callstack array is empty user will see just "subscription called from:" and empty line, which might be quite confusing for him.

@freak4pc
Copy link
Collaborator

left a comment

There are a few English grammar issues with this. I can edit it for you if you’d like.

Documentation/GettingStarted.md Outdated Show resolved Hide resolved

@MortyMerr MortyMerr force-pushed the MortyMerr:feature/Hooks branch 2 times, most recently from 264514e to 762e25d May 28, 2019

@MortyMerr

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

If there are English grammar issues, I will appreciate any help with fixing them :)
Thanks

@MortyMerr MortyMerr force-pushed the MortyMerr:feature/Hooks branch from 762e25d to 6d6a004 Jun 2, 2019

Documentation/GettingStarted.md Outdated Show resolved Hide resolved

@MortyMerr MortyMerr force-pushed the MortyMerr:feature/Hooks branch from 6d6a004 to 3ded78b Jun 3, 2019

@freak4pc freak4pc merged commit 885637e into ReactiveX:develop Jun 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.