This repository was archived by the owner on Oct 1, 2018. It is now read-only.
refactor(Components): change to app.module and lazy loaded modules #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… use shared module
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
+ Coverage 86.88% 88.46% +1.57%
==========================================
Files 4 7 +3
Lines 61 78 +17
Branches 7 7
==========================================
+ Hits 53 69 +16
- Misses 5 6 +1
Partials 3 3
Continue to review full report at Codecov.
|
ladyleet
approved these changes
Oct 27, 2017
Member
|
@Only1MrAnderson whoops, can you update the branch? @btroncone good to merge if you're 👍 too. |
Contributor
Author
|
@ladyleet @btroncone Branch Updated |
Contributor
Author
|
Please hold off on the merge, found a layout issue with the refactor. |
Contributor
Author
|
@sumitarora @ladyleet G2G |
Collaborator
|
@sumitarora @ladyleet - can I get approvals before the merge since there is code change after your initial approval. Thanks ! |
Member
|
@ashwin-sureshkumar LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor(Components): change to app.module and lazy loaded modules to use the shared module. change to app.component to use new toolbar component