Skip to content
This repository was archived by the owner on Oct 1, 2018. It is now read-only.

Conversation

@sumitarora
Copy link
Collaborator

Closes: #67

@codecov-io
Copy link

codecov-io commented Oct 29, 2017

Codecov Report

Merging #141 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #141   +/-   ##
=======================================
  Coverage   88.46%   88.46%           
=======================================
  Files           7        7           
  Lines          78       78           
  Branches        7        7           
=======================================
  Hits           69       69           
  Misses          6        6           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dde8c45...17e6b06. Read the comment docs.

@ladyleet
Copy link
Member

Looks like the branch is out of sync @sumitarora

@sumitarora
Copy link
Collaborator Author

@ladyleet done

@ladyleet
Copy link
Member

@sumitarora oh noes. otra vez por favor.

@@ -1,6 +1,77 @@
import { OperatorDoc } from '../operator.model';
import { OperatorDoc } from "../operator.model";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use single quote here. This will be handled automagically once #148 is merged.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xlozinguez It doesn't take effect as pre-commit hook change it to double quotes again. Probably would be done after #148 is merged.

@xlozinguez
Copy link

LGTM once single quote issue is fixed

@ashwin-sureshkumar
Copy link
Collaborator

@sumitarora please rebase to master.

@sumitarora
Copy link
Collaborator Author

@ashwin-sureshkumar done

@ashwin-sureshkumar ashwin-sureshkumar merged commit c3e4561 into ReactiveX:master Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants