Skip to content
This repository was archived by the owner on Oct 1, 2018. It is now read-only.

Conversation

@nicolaisueper
Copy link
Contributor

Point out that combineLatest starts to emit when all sources have emitted at least once and a hint
to startWith for a default first value

@codecov-io
Copy link

codecov-io commented Nov 17, 2017

Codecov Report

Merging #149 into master will decrease coverage by 2.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
- Coverage   91.02%   88.46%   -2.57%     
==========================================
  Files           7        7              
  Lines          78       78              
  Branches        5        7       +2     
==========================================
- Hits           71       69       -2     
  Misses          6        6              
- Partials        1        3       +2
Impacted Files Coverage Δ
src/app/operators/operators.component.ts 80.48% <0%> (-4.88%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d02c2fb...6f6ae8a. Read the comment docs.

type: 'Tip',
text: `
Note: combineLatest only start to emit when all sources have emitted at least once.
By adding a default start value to the sources with .startWith, it will activate right away.
Copy link
Collaborator

@btroncone btroncone Nov 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo, update only start with will only start . Also, since we are referencing startWith here can we make that a link? Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For sure :) I'm onto it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Angular sanitizes the links inside the tips. Has this happened before anywhere?

Copy link
Contributor Author

@nicolaisueper nicolaisueper Nov 17, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've written a safeHtml pipe which returns this._sanitizer.bypassSecurityTrustHtml(html);, equivalent to the existing safeUrl pipe. Is this an acceptable solution for you?

@nicolaisueper
Copy link
Contributor Author

Sorry for the commit message error, fixed it a minute ago.

Copy link
Contributor

@luillyfe luillyfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge 👍

@ladyleet
Copy link
Member

thx @nicolaisueper! can you rebase pls?

@nicolaisueper
Copy link
Contributor Author

@ladyleet done!

@ashwin-sureshkumar
Copy link
Collaborator

Sorry @nicolaisueper, can you please rebase once more.

@nicolaisueper
Copy link
Contributor Author

@ashwin-sureshkumar There's only one commit inside this PR, I don't really know what I should do. Can you please explain to me how I should rebase?

@nicolaisueper
Copy link
Contributor Author

This is (almost) the first foreign open source project I'm contributing to, so please excuse my start difficulties :)

@ashwin-sureshkumar
Copy link
Collaborator

ashwin-sureshkumar commented Nov 23, 2017

Not a problem at all. Please follow below steps, I am being very explicit ignore if you have already done lot of these.

git remote -v

The above should two remote addresses

origin	git@github.com:nicolaisueper/rxjs-docs.git (fetch)
origin	git@github.com:nicolaisueper/rxjs-docs.git (push)
upstream	git@github.com:ReactiveX/rxjs-docs.git (fetch)
upstream	git@github.com:ReactiveX/rxjs-docs.git (push)

If you have only origin then please perform the below step

git remote add upstream git@github.com:ReactiveX/rxjs-docs.git

Then perform below steps

git checkout master 
git pull --ff upstream master
git checkout 143-combineLatest-tip
git rebase master -i 
git push -f

Also, please refer https://github.com/ReactiveX/rxjs-docs/blob/master/CONTRIBUTING.md

@nicolaisueper - Let me know if this help

Point out that `combineLatest` starts to emit when all sources have emitted at least once and a hint
to `startWith` for a default first value
@nicolaisueper
Copy link
Contributor Author

@ashwin-sureshkumar Thanks a lot! I thought I should only rebase the commits inside this PR. Now rebased onto master.

@ashwin-sureshkumar
Copy link
Collaborator

@nicolaisueper - Thank you !

@ashwin-sureshkumar ashwin-sureshkumar merged commit 8e84e13 into ReactiveX:master Nov 24, 2017
@ladyleet
Copy link
Member

This is so great! Thank you @nicolaisueper and @ashwin-sureshkumar! 💯

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants