Skip to content
This repository was archived by the owner on Oct 1, 2018. It is now read-only.

Conversation

@necoline
Copy link
Contributor

No description provided.

@rxjs-bot
Copy link

Fails
🚫

commit message does not follows conventional change log (2)

Warnings
⚠️

❗ Big PR (1)

(1) : Pull Request size seems relatively large. If Pull Request contains multiple changes, split each into separate PR will helps faster, easier review.

(2) : RxJS uses conventional change log to generate changelog automatically. It seems some of commit messages are not following those, please check contributing guideline and update commit messages.

Generated by 🚫 dangerJS

@ladyleet
Copy link
Member

@necoline WOOHOO your first PR for RxJS docs!!!!!!

</mat-icon>
</button>
<span class="title" fxFlex> RxJS Docs </span>
<span class="title" fxFlex> WARNING: This is BETA site </span>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@necoline can we have a - For the current RxJS docs, visit http://reactivex.io/rxjs under that?

@btroncone
Copy link
Collaborator

Thanks! 👍

@ashwin-sureshkumar
Copy link
Collaborator

ashwin-sureshkumar commented Dec 2, 2017

@necoline - Thanks for the PR. Just a small change in your commit message since it doesn't follow the commit message guidelines.

Contribution guidelines has the commit message guideline information

Let me know if you need any help.

@ashwin-sureshkumar
Copy link
Collaborator

@necoline - Just following up on this PR. Let me know if you need any help

@ladyleet ladyleet merged commit 13cf09b into ReactiveX:master Dec 15, 2017
ladyleet added a commit that referenced this pull request Dec 15, 2017
@ladyleet
Copy link
Member

@necoline woot! merged <3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants