Skip to content
This repository was archived by the owner on Oct 1, 2018. It is now read-only.

Conversation

@sumitarora
Copy link
Collaborator

@sumitarora sumitarora commented Dec 6, 2017

Closes: #68

@codecov-io
Copy link

codecov-io commented Dec 6, 2017

Codecov Report

Merging #182 into master will decrease coverage by 2.64%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #182      +/-   ##
==========================================
- Coverage   77.14%   74.49%   -2.65%     
==========================================
  Files          15       10       -5     
  Lines         175      149      -26     
  Branches        7        7              
==========================================
- Hits          135      111      -24     
+ Misses         40       38       -2
Impacted Files Coverage Δ
src/app/material/material.module.ts 100% <0%> (ø) ⬆️
src/app/companies/companies-list.ts
...pp/team/social-sharing/social-sharing.component.ts
src/app/companies/company.service.ts
src/app/team/member.component.ts
src/app/team/team.service.ts

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8824cbe...403d845. Read the comment docs.

@niklas-wortmann
Copy link
Member

For me it looks good. Is it ok to give an approval, or should this be made by "core contributors"?

@sumitarora
Copy link
Collaborator Author

@jwo719 You can also approve it.

@ashwin-sureshkumar
Copy link
Collaborator

@sumitarora - can you rebase, also can you please fix single quotes.

Copy link
Collaborator

@ashwin-sureshkumar ashwin-sureshkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix quotes to be single.

@sumitarora
Copy link
Collaborator Author

@ashwin-sureshkumar done

@ashwin-sureshkumar ashwin-sureshkumar merged commit c129471 into ReactiveX:master Jan 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants