This repository was archived by the owner on Oct 1, 2018. It is now read-only.
docs(operators): add documentation for partition #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #224 +/- ##
=======================================
Coverage 77.14% 77.14%
=======================================
Files 15 15
Lines 175 175
Branches 7 7
=======================================
Hits 135 135
Misses 40 40Continue to review full report at Codecov.
|
niklas-wortmann
suggested changes
Dec 30, 2017
Member
niklas-wortmann
left a comment
niklas-wortmann
left a comment
There was a problem hiding this comment.
Except the little syntax error, everything looks really great to me!
| name: 'partition', | ||
| operatorType: 'transformation', | ||
| signature: | ||
| 'public partition(predicate: function(value: T, index: number): boolean, thisArg: any): [Observable<T>, Observable<T>', |
Member
There was a problem hiding this comment.
here is a little syntax error. At the end, there is a missing ]
niklas-wortmann
approved these changes
Dec 30, 2017
ashwin-sureshkumar
approved these changes
Dec 31, 2017
Collaborator
|
@hardikpthv - Could please rebase with master |
Member
|
thank you for merging this @ashwin-sureshkumar! and thx @hardikpthv for the PR! amaze! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #120