This repository was archived by the owner on Oct 1, 2018. It is now read-only.
fix (Component): add accessibility features #37
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Wrapped the toolbar in a <header /> element to allow the proper classification of the toolbar. 2. wrapped the <router-outlet /> element with a <main /> element instead of a <div /> element 3. Added a role="navigation" to the sidenav for screenreaders 4. Added an aria-label="menu" tag to the mat-icon-button because screen readers couldn't identify text to read inside the element. 5. Bumped up the font-weight on the .title element to fulfill color contrast requirements. There is still a color contrast problem within the side menu. The current color is #e91e63, but it should be #E4165C to fulfill color contrast requirements.
Generated by 🚫 dangerJS |
Collaborator
|
Awesome! 👍🏻 |
knitcodemonkey
changed the title
ladyleet
approved these changes
Oct 16, 2017
Member
|
merged thanksssss! :) this was amaze |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix (Component): add accessibility features
Add accessibility features to the documentation for wider usability amongst the users.
<header />element to allow the proper classification of the toolbar<main />element instead of a<div />elementrole="navigation"to the sidenav for screenreadersaria-label="menu"tag to themat-icon-buttonbecause screen readers couldn't identify text to read inside the element.titleelement to fulfill color contrast requirementsThere is still a color contrast problem within the side menu. The current color is
#e91e63, but it should be#E4165Cto fulfill color contrast requirements. Additional work will also need to be done on the menu to add navigation via arrow keys.This does not close any existing issues, and should not include any breaking changes.