-
Notifications
You must be signed in to change notification settings - Fork 61
docs(README.md, CONTRIBUTING.md): Update and Add respectively #44
Conversation
Mimic the RxJs commit wizard for use with rxjs-docs. The rxjs-github-bot requires a certain format for git messages. The commitizen and cs-conventional-changelog modules help make that a breeze. No breaking changes. Just an added feature.
add reference to code of conduct and new contributing file none
…t currently exist docs have not been installed as of yet, so I removed the copied reference to them none
Adding same license to rxjs-docs as exists in RxJs none
Change badge links from rxjs to rxjs-docs none
Add ability for readme.md to identify npm usage none
…s to coverage and documentation none
…info Add goals, building/testing scripts information, and commit message info none
Title referenced RxJs. Change to RxJs Docs none
Generated by 🚫 dangerJS |
|
LGTM @knittingcodemonkey! thanks for your 2nd contribution! @kwonoj 👍? |
| is necessary because release notes are automatically generated from these messages. | ||
|
|
||
| ```shell | ||
| git commit -a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not for this PR, but probably we should have same tooling as rxjs repo to support npm run commit commit wizard.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
welp, actually this PR has it - let's add into guides as well (and recommend to use it)
|
Super nitty comment otherwise lgtm. I'd recommdnd ppl use |
|
Felt so good to merge this! Thx @knittingcodemonkey! |
No breaking changes. Assists in closing #19