Skip to content
This repository was archived by the owner on Oct 1, 2018. It is now read-only.

Conversation

@Only1MrAnderson
Copy link
Contributor

@Only1MrAnderson Only1MrAnderson commented Oct 21, 2017

refactor(Component): Created Shared Module and moved the toolbar to its own component

@rxjs-bot
Copy link

rxjs-bot commented Oct 21, 2017

Fails
🚫

commit message does not follows conventional change log (1)

(1) : RxJS uses conventional change log to generate changelog automatically. It seems some of commit messages are not following those, please check contributing guideline and update commit messages.

Generated by 🚫 dangerJS

@Only1MrAnderson
Copy link
Contributor Author

I am lost on this danger file failure. Is this on my end or a problem with Travis-ci?

@ladyleet
Copy link
Member

ladyleet commented Oct 21, 2017

🚗 highway to the danger zone! pinging @kwonoj for comments on this. thx @Only1MrAnderson !

@kwonoj
Copy link
Member

kwonoj commented Oct 21, 2017

Please rebase to master includes danger update.

@Only1MrAnderson
Copy link
Contributor Author

@kwonoj Updated

@ladyleet
Copy link
Member

@kwonoj or @btroncone can one of you review and merge this?

@btroncone
Copy link
Collaborator

@Only1MrAnderson This is currently out of date, could you update? Everything else lgtm, thanks! 👍

@Only1MrAnderson
Copy link
Contributor Author

@kwonoj Danger file issue again? Otherwise updated @btroncone

The command "if [ -n "DANGER_GITHUB_API_TOKEN" ]; then echo {} > ./.babelrc && npx danger; fi" exited with 1.

@kwonoj
Copy link
Member

kwonoj commented Oct 26, 2017

@Only1MrAnderson no, it's valid. should conform danger comments: #58 (comment)

@Only1MrAnderson
Copy link
Contributor Author

@ladyleet @kwonoj Hey Guys, I think I completely messed up this PR trying to resolve prior commit messages. Any thoughts on closing this one and I will submit a fresh one with the required message style etc... ?

@ladyleet
Copy link
Member

@Only1MrAnderson sure, whatever you like.

@Only1MrAnderson
Copy link
Contributor Author

Only1MrAnderson commented Oct 27, 2017

@ladyleet Closing in favor of #135 . I think I finally have down the process. 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants