Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tslint and typescript should not be dependencies #68

Open
wants to merge 1 commit into
base: master
from

Conversation

@JounQin
Copy link

JounQin commented Oct 5, 2019

@mgechev They have already been declared as peerDependencies.

Listing them as dependencies resolve a lot of issues like following when upgrading deps:

error An unexpected error occurred: "could not find a copy of typescript to link in ...\\node_modules\\rxjs-tslint\\node_modules".
They have already been declared as `peerDependencies`.

Listing them as `dependencies` resolve a lot of issues like following when upgrading deps:

```sh
error An unexpected error occurred: "could not find a copy of typescript to link in ...\\node_modules\\rxjs-tslint\\node_modules".
```
@JounQin

This comment has been minimized.

Copy link
Author

JounQin commented Oct 20, 2019

@mgechev Please, help to review...

@JounQin

This comment has been minimized.

Copy link
Author

JounQin commented Nov 18, 2019

So disappointed about this.
I'll publish my own fork then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.