From 519000bde19d23e3639ec9d9a2c8b4ed17b9a426 Mon Sep 17 00:00:00 2001 From: Francois Valdy Date: Thu, 11 Feb 2016 00:12:35 +0100 Subject: [PATCH] docs(ALL): fix typos --- CHANGELOG.md | 6 +++--- CONTRIBUTING.md | 2 +- MIGRATION.md | 2 +- spec/Observable-spec.js | 2 +- src/operator/distinct.ts | 2 +- src/operator/distinctKey.ts | 2 +- src/operator/find.ts | 2 +- src/operator/mapTo.ts | 2 +- src/symbol/rxSubscriber.ts | 2 +- 9 files changed, 11 insertions(+), 11 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 532a82bb31..4aa4ad6164 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,13 +9,13 @@ * **every:** remove eager predicate calls ([74c2c44](https://github.com/ReactiveX/RxJS/commit/74c2c44)) * **forkJoin:** fix forkJoin to complete if sources Array is empty. ([412b13b](https://github.com/ReactiveX/RxJS/commit/412b13b)) * **groupBy:** does not emit on unsubscribed group ([6d08705](https://github.com/ReactiveX/RxJS/commit/6d08705)) -* **groupBy:** fix groupBy to use lift(), supports composability ([815cfae](https://github.com/ReactiveX/RxJS/commit/815cfae)), closes [#1085](https://github.com/ReactiveX/RxJS/issues/1085) [#1085](https://github.com/ReactiveX/RxJS/issues/1085) +* **groupBy:** fix groupBy to use lift(), supports composability ([815cfae](https://github.com/ReactiveX/RxJS/commit/815cfae)), closes [#1085](https://github.com/ReactiveX/RxJS/issues/1085) * **merge/concat:** passed scalar observables will now complete properly ([c01b92f](https://github.com/ReactiveX/RxJS/commit/c01b92f)), closes [#1150](https://github.com/ReactiveX/RxJS/issues/1150) -* **MergeMapSubscriber:** clearfy type definitions for MergeMapSubscriber's members ([4ee5f02](https://github.com/ReactiveX/RxJS/commit/4ee5f02)) +* **MergeMapSubscriber:** clarify type definitions for MergeMapSubscriber's members ([4ee5f02](https://github.com/ReactiveX/RxJS/commit/4ee5f02)) * **Observable.forEach:** errors thrown in nextHandler reject returned promise ([c5ead88](https://github.com/ReactiveX/RxJS/commit/c5ead88)), closes [#1184](https://github.com/ReactiveX/RxJS/issues/1184) * **Observer:** fix typing to allow observation via partial observables with PartialObservableMacro -[Macro performance tests](perf/macro) are best written for scenarios where many object instance allocations (or deallocations) are occuring. Operators +[Macro performance tests](perf/macro) are best written for scenarios where many object instance allocations (or deallocations) are occurring. Operators that create a lot of child subscriptions, or operators that emit new objects like Observables and Subjects are definitely worth creating macro performance tests for. diff --git a/MIGRATION.md b/MIGRATION.md index a10816f63d..19d1fc4eea 100644 --- a/MIGRATION.md +++ b/MIGRATION.md @@ -235,6 +235,6 @@ didn't make sense in a JavaScript context (for example: `currentThread` when the ## Unimplemented Operators/Features -If there is a feature that used to exist in RxJS 4, but no longer does in RxJS 5, please be sure to file an issue (and preferrably a PR). +If there is a feature that used to exist in RxJS 4, but no longer does in RxJS 5, please be sure to file an issue (and preferably a PR). In your issue, please describe the use case you have for the operator so we can better understand your need and prioritize it, and/or find and alternative way to compose the desired behavior. diff --git a/spec/Observable-spec.js b/spec/Observable-spec.js index 587a8d576b..f40ce26ebd 100644 --- a/spec/Observable-spec.js +++ b/spec/Observable-spec.js @@ -330,7 +330,7 @@ describe('Observable.lift', function () { }); it('should allow injecting behaviors into all subscribers in an operator ' + - 'chain when overriden', function (done) { + 'chain when overridden', function (done) { // The custom Subscriber var log = []; function LogSubscriber() { diff --git a/src/operator/distinct.ts b/src/operator/distinct.ts index 4c59ba9d31..80255d8f64 100644 --- a/src/operator/distinct.ts +++ b/src/operator/distinct.ts @@ -11,7 +11,7 @@ import {subscribeToResult} from '../util/subscribeToResult'; * If a comparator function is provided, then it will be called for each item to test for whether or not that value should be emitted. * If a comparator function is not provided, an equality check is used by default. * As the internal HashSet of this operator grows larger and larger, care should be taken in the domain of inputs this operator may see. - * An optional paramter is also provided such that an Observable can be provided to queue the internal HashSet to flush the values it holds. + * An optional parameter is also provided such that an Observable can be provided to queue the internal HashSet to flush the values it holds. * @param {function} [compare] optional comparison function called to test if an item is distinct from previous items in the source. * @param {Observable} [flushes] optional Observable for flushing the internal HashSet of the operator. * @returns {Observable} an Observable that emits items from the source Observable with distinct values. diff --git a/src/operator/distinctKey.ts b/src/operator/distinctKey.ts index 63deb9ee9c..de2962867d 100644 --- a/src/operator/distinctKey.ts +++ b/src/operator/distinctKey.ts @@ -7,7 +7,7 @@ import {Observable} from '../Observable'; * If a comparator function is provided, then it will be called for each item to test for whether or not that value should be emitted. * If a comparator function is not provided, an equality check is used by default. * As the internal HashSet of this operator grows larger and larger, care should be taken in the domain of inputs this operator may see. - * An optional paramter is also provided such that an Observable can be provided to queue the internal HashSet to flush the values it holds. + * An optional parameter is also provided such that an Observable can be provided to queue the internal HashSet to flush the values it holds. * @param {string} key string key for object property lookup on each item. * @param {function} [compare] optional comparison function called to test if an item is distinct from previous items in the source. * @param {Observable} [flushes] optional Observable for flushing the internal HashSet of the operator. diff --git a/src/operator/find.ts b/src/operator/find.ts index 11e853eb27..74f63f22bd 100644 --- a/src/operator/find.ts +++ b/src/operator/find.ts @@ -4,7 +4,7 @@ import {Subscriber} from '../Subscriber'; /** * Returns an Observable that searches for the first item in the source Observable that - * matches the specified condition, and returns the first occurence in the source. + * matches the specified condition, and returns the first occurrence in the source. * @param {function} predicate function called with each item to test for condition matching. * @returns {Observable} an Observable of the first item that matches the condition. */ diff --git a/src/operator/mapTo.ts b/src/operator/mapTo.ts index a5f29e5698..56674d156b 100644 --- a/src/operator/mapTo.ts +++ b/src/operator/mapTo.ts @@ -8,7 +8,7 @@ import {Observable} from '../Observable'; * * * @param {any} value the value to map each incoming value to - * @returns {Observable} an observable of the passed value that emits everytime the source does + * @returns {Observable} an observable of the passed value that emits every time the source does */ export function mapTo(value: R): Observable { return this.lift(new MapToOperator(value)); diff --git a/src/symbol/rxSubscriber.ts b/src/symbol/rxSubscriber.ts index 2eb5a9abe8..76cf97a0e0 100644 --- a/src/symbol/rxSubscriber.ts +++ b/src/symbol/rxSubscriber.ts @@ -1,7 +1,7 @@ import {SymbolShim} from '../util/SymbolShim'; /** - * rxSubscriber symbol is a symbol for retreiving an "Rx safe" Observer from an object + * rxSubscriber symbol is a symbol for retrieving an "Rx safe" Observer from an object * "Rx safety" can be defined as an object that has all of the traits of an Rx Subscriber, * including the ability to add and remove subscriptions to the subscription chain and * guarantees involving event triggering (can't "next" after unsubscription, etc).