Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(pipeable): goodbye lettable, hello pipeable. #3224

Merged
merged 1 commit into from Jan 12, 2018

Conversation

@benlesh
Copy link
Member

benlesh commented Jan 12, 2018

WTF is a "lettable" anyway? I dunno... do you? Let's call it "Pipeable"... because it can be piped. It sounds silly too, but it makes a little more sense.

@jayphelps

This comment has been minimized.

Copy link
Member

jayphelps commented Jan 12, 2018

The new RxJS theme song:

@rxjs-bot

This comment has been minimized.

Copy link

rxjs-bot commented Jan 12, 2018

Messages
📖

CJS: 1381.4KB, global: 750.1KB (gzipped: 120.6KB), min: 145.4KB (gzipped: 31.4KB)

Generated by 🚫 dangerJS

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 12, 2018

Coverage Status

Coverage remained the same at 97.097% when pulling 4085e89 on benlesh:lettable-no-more into 778c957 on ReactiveX:master.

@benlesh benlesh merged commit a571bc1 into ReactiveX:master Jan 12, 2018
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 97.097%
Details
3. `switch` -> `switchAll`
4. `finally` -> `finalize`

The `let` operator is now part of `Observable` as `pipe` and cannot be imported.

This comment has been minimized.

Copy link
@staltz

staltz Jan 13, 2018

Member

I think you meant the other way around?

@lock

This comment has been minimized.

Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.