Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rxjs): move rxjs/create into rxjs #3299

Merged
merged 1 commit into from Feb 6, 2018

Conversation

benlesh
Copy link
Member

@benlesh benlesh commented Feb 6, 2018

Moves all Observable creation functions under the rxjs namespace.

BREAKING CHANGE: rxjs/create items are now exported from rxjs

Based on several other discussions we've had, rxjs/create was a little less ergonomic than we'd have liked. Also with the move to using the EMPTY constant, it seemed to make more sense.

Moves all Observable creation functions under the `rxjs` namespace.

BREAKING CHANGE: `rxjs/create` items are now exported from `rxjs`
@benlesh benlesh requested a review from kwonoj February 6, 2018 04:31
@rxjs-bot
Copy link

rxjs-bot commented Feb 6, 2018

Messages
📖

CJS: 1360.3KB, global: 728.4KB (gzipped: 117.7KB), min: 140.5KB (gzipped: 30.6KB)

Generated by 🚫 dangerJS

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.506% when pulling 4b654ab on benlesh:create-to-rxjs into a24146f on ReactiveX:master.

Copy link
Member

@jayphelps jayphelps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants