Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
left a comment
First of all thanks a lot for this pr!
mostly it's usage of var instead of let or const and using old creation functions, e.g.
If there is anything unclear don't hesitate to ask me.
@bhaidar If you're looking to do this, can you
What was in there definitely needs to be updated, but what is in this PR reads more like a personal blog entry, and seems like it's completely different. I REALLY appreciate the time and thought you put into this, but I'm not sure we can merge this one because it loses context and history, and I can't say I agree with every point in it.
I really think you should take this material and publish it as a blog, and I'd be happy help you refine it and spread it. The RxJS docs are more for approved practices that come from the core team, and this would require a lot of discussion and refinement.
Sorry for the confusion on this. This content usdd to be in thd old docs and therefore I thought it needed to be migrated. Are there maybe some bits we could use as starting point for the receipt, we planned to have at some point.
I'm really sorry for all the confusion, totally my fault.
I had some issues at first running and updating the docs locally and that explains why most of the changes I've done were lost!
In all cases, I've updated once again the docs.
As Jan said, those are the tutorials from the old docs. I understood from Jan I need to upgrade to RxJs6.
In all cases, I will update the branch and let me know how you would like to proceed.
If there are other things to upgrade from old docs please let me know to work on them.