Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(throttleTime): emit single value with trailing enabled #4564
throttleTime didn't emit single values when leading was disabled and trailing enabled.
I've added tests to verify this behavior and added another commit to fix it.
Pull Request Test Coverage Report for Build 8355
I've reviewed this, but I'd like to make some changes to the test descriptions - some of which are separate to the changes you've made in this PR. I'm unable to push make changes to your PR, so you can either ensure that this box is checked:
Or you can apply the following patch that includes the changes:
…#4564) * test(throttleTime): test single value with trailing enabled Test if throttleTime emits when only a single value is emitted from the source with leading enabled/disabled and trailing enabled. * fix(throttleTime): fix single value with leading disabled, trailing enabled Emit single value with leading disabled, trailing enabled. Closes ReactiveX#2859 and ReactiveX#4491. * chore: improve test descriptions And remove an asDiagram call made with the same argument. Signed-off-by: Matthias Kunnen <firstname.lastname@example.org>