Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(of): deprecation warning when using of as intended #4724

Merged
merged 1 commit into from May 10, 2019

Conversation

@evertbouw
Copy link
Contributor

commented Apr 23, 2019

Description:

Typescript picks the deprecated signature when using of. By moving the signature to the bottom it will pick the correct one. Removed the deprecation comment instead

Related issue (if exists):

closes #4723

@coveralls

This comment has been minimized.

Copy link

commented Apr 23, 2019

Pull Request Test Coverage Report for Build 8470

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.2%) to 96.842%

Files with Coverage Reduction New Missed Lines %
src/internal/scheduled/scheduleObservable.ts 1 92.31%
src/internal/scheduled/scheduled.ts 1 79.41%
src/internal/scheduled/scheduleIterable.ts 3 89.19%
Totals Coverage Status
Change from base Build 8469: 0.2%
Covered Lines: 5796
Relevant Lines: 5985

💛 - Coveralls
Copy link
Collaborator

left a comment

LGTM, but I have one minor change request.

src/internal/observable/of.ts Outdated Show resolved Hide resolved
@evertbouw evertbouw force-pushed the evertbouw:master_fix_of branch from c6e9c5a to 616b27b Apr 23, 2019
Copy link
Collaborator

left a comment

LGTM

@mtraynham

This comment has been minimized.

Copy link

commented Apr 24, 2019

@cartant @evertbouw , can we change the PR to remove deprecation warnings for the other methods that also don't pass a scheduler (e.g. from, concat, merge, startWith and endWith)?

From #4595:

This deprecates versions of from, concat, merge, startWith and endWith that allow passing a scheduler.

I assume the variants that don't pass a scheduler should not be deprecated?

@cartant

This comment has been minimized.

Copy link
Collaborator

commented Apr 25, 2019

@mtraynham If there is a specific problem with the operators you are talking about, please open another issue and fill out the template with the specifics. As it stands, I don't have all of the information and I don't want to spend anytime looking into this based on what I've assumed you are talking about.

Note that the concat and merge operators are deprecated for a different reason.

@Stefie Stefie referenced this pull request Apr 26, 2019
src/internal/observable/of.ts Outdated Show resolved Hide resolved
@evertbouw evertbouw force-pushed the evertbouw:master_fix_of branch from 616b27b to 0c8ad97 May 9, 2019
@benlesh benlesh merged commit da69c16 into ReactiveX:master May 10, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 96.842%
Details
@lock lock bot locked as resolved and limited conversation to collaborators Jun 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants
You can’t perform that action at this time.