Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forkJoin): test for object literal #4741

merged 2 commits into from May 2, 2019


Copy link

commented Apr 26, 2019


This PR fixes a problem with forkJoin's inspection of its first argument to determine whether or not it should be joining the properties of an object literal.

The current code checks to see if the argument is not an Observable and if it isn't, it proceeds as if it has been called with an object literal. However. the argument could be another ObservableInput - like a Promise.

This PR adds a failing test and changes the check to compare the argument's prototype to Object.prototype.

Related issue (if exists): #4737

@cartant cartant requested a review from benlesh Apr 26, 2019
@cartant cartant force-pushed the cartant:issue-4737 branch from c16ffaf to 7cb2ab9 Apr 26, 2019

This comment has been minimized.

Copy link

commented Apr 26, 2019

Pull Request Test Coverage Report for Build 8422

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 96.677%

Files with Coverage Reduction New Missed Lines %
src/internal/OuterSubscriber.ts 1 50.0%
Totals Coverage Status
Change from base Build 8414: -0.2%
Covered Lines: 5207
Relevant Lines: 5386

💛 - Coveralls
benlesh approved these changes May 2, 2019
@benlesh benlesh merged commit c11e1b3 into ReactiveX:master May 2, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
continuous-integration/travis-ci/pr The Travis CI build passed
coverage/coveralls Coverage decreased (-0.2%) to 96.677%
BioPhoton added a commit to BioPhoton/rxjs that referenced this pull request May 15, 2019
* test(forkJoin): add failing test for ReactiveX#4737

* fix(forkJoin): test for object literal not observable

Closes ReactiveX#4737.
@lock lock bot locked as resolved and limited conversation to collaborators Jun 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
3 participants
You can’t perform that action at this time.