Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pairwise): make it recursion-proof #4743

Merged
merged 1 commit into from May 9, 2019

Conversation

@thorn0
Copy link
Contributor

commented Apr 26, 2019

Description: pairwise calls next before saving the current value as the previous one, which makes it not recursively re-enterable. If its subscriber synchronously triggers the input observable, pairwise erroneously emits a pair with the wrong previous value.

Related issue: reduxjs/redux#3404

@thorn0 thorn0 force-pushed the thorn0:fix-pairwise branch from 8d2910b to ee7dc85 Apr 26, 2019
@coveralls

This comment has been minimized.

Copy link

commented Apr 27, 2019

Pull Request Test Coverage Report for Build 8430

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 96.678%

Files with Coverage Reduction New Missed Lines %
src/internal/OuterSubscriber.ts 1 50.0%
Totals Coverage Status
Change from base Build 8414: -0.2%
Covered Lines: 5210
Relevant Lines: 5389

💛 - Coveralls
@thorn0 thorn0 changed the title fix(pairwise): make it recursion-pron fix(pairwise): make it recursion-proof Apr 27, 2019
@thorn0 thorn0 force-pushed the thorn0:fix-pairwise branch 2 times, most recently from d0d5c12 to 8f15593 Apr 27, 2019
@thorn0 thorn0 force-pushed the thorn0:fix-pairwise branch from 8f15593 to 5b27ea7 Apr 27, 2019
Copy link
Collaborator

left a comment

LGTM

@benlesh benlesh merged commit 21ab261 into ReactiveX:master May 9, 2019
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.2%) to 96.678%
Details
BioPhoton added a commit to BioPhoton/rxjs that referenced this pull request May 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jun 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.