Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(race): ignore latter sources after first complete or error #4809

Merged
merged 2 commits into from Jun 4, 2019

Conversation

@cartant
Copy link
Collaborator

commented May 25, 2019

Description:

The implementation of race ignores latter sources if an earlier source emits a next notification. This PR fixes the implementation so that latter sources are also ignored if an earlier source wins the race by emitting either a complete or an error notification.

This PR adds failing tests that are fixed by the change.

For more information, see the related issue - it contains code snippets that highlight the inconsistent behaviour.

Related issue (if exists): #4808

@benlesh

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

Because subscribing to Observables can have side effects, this will be a breaking change, and we can't land it in 6.x. However we could land it in master.

@benlesh
benlesh approved these changes Jun 4, 2019
@benlesh benlesh merged commit f31c3df into ReactiveX:master Jun 4, 2019
5 checks passed
5 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: dtslint Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: typescript3 Your tests passed on CircleCI!
Details
@lock lock bot locked as resolved and limited conversation to collaborators Jul 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.