Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rxjs-compat): removed for v7 #4839

Merged
merged 1 commit into from Jun 10, 2019

Conversation

@benlesh
Copy link
Member

commented Jun 6, 2019

Removes all files that were solely related to v6 backward compatibility with v5, and/or related to schematic migration from v5 to v6.

Note that there were some changes required to tsconfig files based off of changes to the build process (in order to stop building compatibility related files)

BREAKING CHANGE: rxjs/Rx is no longer a valid import site.
BREAKING CHANGE: rxjs-compat is not published for v7 (yet)

BREAKING CHANGE: `rxjs/Rx` is no longer a valid import site.
BREAKING CHANGE: `rxjs-compat` is not published for v7 (yet)
@benlesh benlesh requested review from jasonaden and cartant Jun 7, 2019
@cartant
cartant approved these changes Jun 9, 2019
Copy link
Collaborator

left a comment

LGTM. Just a question about the types location in the package.json.

@@ -222,8 +198,5 @@
"engines": {
"npm": ">=2.0.0"
},
"typings": "./dist/package/Rx.d.ts",

This comment has been minimized.

Copy link
@cartant

cartant Jun 9, 2019

Collaborator

If rxjs/Rx is no longer a valid import, is ./dist/package/Rx.d.ts going to be were the types are?

This comment has been minimized.

Copy link
@benlesh

benlesh Jun 10, 2019

Author Member

Hmmm... that's a good question. I think we're going to need to take another pass through the module settings in package.json to ensure we're going about this right. We have have a little time, we just need to sort it out before the first alpha release.

@benlesh benlesh merged commit 79b1b95 into ReactiveX:master Jun 10, 2019
5 checks passed
5 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: dtslint Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: typescript3 Your tests passed on CircleCI!
Details
@lock lock bot locked as resolved and limited conversation to collaborators Jul 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.