Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TestScheduler): expose `frameTimeFactor` property #4977

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@benlesh
Copy link
Member

commented Aug 22, 2019

  • Makes frameTimeFactor public so people do not have to cast in TypeScript
  • Deprecates frameTimeFactor on VirtualTimeScheduler as it is not used in that class, it
    is really only intended to be used for TestScheduler marble diagrams
  • Deprecates index on VirtualTimeScheduler because it is a leaked implementation detail
  • Adds documentation
- Makes `frameTimeFactor` public so people do not have to cast in TypeScript
- Deprecates `frameTimeFactor` on `VirtualTimeScheduler` as it is not used in that class, it
is really only intended to be used for `TestScheduler` marble diagrams
- Deprecates `index` on `VirtualTimeScheduler` because it is a leaked implementation detail
- Adds documentation
@benlesh benlesh requested a review from cartant Aug 22, 2019
@benlesh

This comment has been minimized.

Copy link
Member Author

commented Aug 22, 2019

Copy link
Collaborator

left a comment

LGTM

@benlesh benlesh merged commit 8c32ed0 into ReactiveX:master Sep 3, 2019
5 checks passed
5 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: dtslint Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: typescript3 Your tests passed on CircleCI!
Details
@lock lock bot locked as resolved and limited conversation to collaborators Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.